Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[find] Remove find extension #1343

Merged
merged 2 commits into from
Mar 4, 2020
Merged

[find] Remove find extension #1343

merged 2 commits into from
Mar 4, 2020

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Mar 3, 2020

Similar to #1251 [managementgroups] Remove managementgroups extension

find command is already in the main CLI.

This PR removes the whole find extension to prevent the doc from being generated and further download from customers.

@jiasli jiasli requested a review from zikalino as a code owner March 3, 2020 10:00
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jiasli/azure-cli-extensions.git@remove-find#subdirectory=src/$EXT&egg=$EXT"

@jiasli jiasli requested review from fengzhou-msft and yonzhan March 3, 2020 10:07
@mirdaki mirdaki mentioned this pull request Mar 3, 2020
Merged
2 tasks
@mirdaki
Copy link
Contributor

mirdaki commented Mar 3, 2020

I've added the extension suppression in this PR.

@jiasli jiasli requested a review from yungezz March 4, 2020 03:12
@jiasli jiasli self-assigned this Mar 4, 2020
@jiasli jiasli merged commit a6a34f0 into Azure:master Mar 4, 2020
@jiasli jiasli deleted the remove-find branch March 4, 2020 06:57
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@jiasli @ManuInNZ
Remove find (Azure#1343)
3f7426f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

@zikalino zikalino Awaiting requested review from zikalino

@yonzhan yonzhan Awaiting requested review from yonzhan

@yungezz yungezz Awaiting requested review from yungezz

Assignees

@jiasli jiasli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiasli @azuresdkci @mirdaki @fengzhou-msft